added service "battery" #116
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi, thanks for this. I'm not familiar with the battery settings but on first inspection it looks like the persist attributes don't look quite right. Can you provide a screen shot of how the setup screen for the battery from the GX device? I'd also like the descriptions to be the Victron ones. Do you have a test script to prove the settings work? Please see similar request here #110. |
|
@freakent Thanks for the feedback and the pointer to a similar PR. I will look into the persist issue as soon as I have physical access to the system again. Just found out in between that there are a few more data items available in the GUI now that represent the switches of the BMS, I will try to add them, as they might be very useful in the VRM log. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
An open-source implementation for a MQTT-based interface to JKBMS on ESP32/ESPHome can be found here: https://github.com/hsteinhaus/esph-gadgets/blob/master/esphome/jkbms-mqtt.yaml